Skip to content

Conversation

mwargan
Copy link

@mwargan mwargan commented Dec 3, 2023

Sometimes we need to use an actual image passed to Markers, for example when we need to downscale the image first. This PR allows users to do so, and supports backwards compatibility and fallback to building an image fromPath if the provided parameter is not an Image already.

This PR basically makes this possible:

        $markerImage = Image::fromPath($icon);

        // Resize the image to the icon dimensions
        $markerImage->downscaleProportion($this->iconWidth, $this->iconHeight);

        $generatedMarkers = new Markers($markerImage);

Sometimes we need to path an actual ready to go image to markers, for example when we need to downscale them first. This PR allows users to do so, and supports backwards compatibility and fallback to building an image fromPath if the provided parameter is not an Image already.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant